Skip to content

feat: transaction-kit core (stage-1 wallet architecture) - #48

Closed
MuncleUscles wants to merge 2 commits into
v0.2-devfrom
feat/transaction-kit-core
Closed

MuncleUscles wants to merge 2 commits into
v0.2-devfrom
feat/transaction-kit-core

Conversation

@MuncleUscles

Copy link
Copy Markdown
Member

Framework-agnostic core of @genlayer/transaction-kit — the trusted fee approval + signing control plane (stage 1 of docs/genlayer-transaction-wallet-architecture.md: direct submission route only; EIP-712 intents, Gateway and ERC-7730 are deliberately out of scope, snap stays an optional verification surface).

  • estimate → PolicyQuote (breakdown: consensus work / execution budget / message bucket; caps; total; refundable)
  • submit → via injected EIP-1193 provider, SDK owns encoding (genlayer-js pinned github:…#v2-dev until the v2 npm release)
  • track → phase updates to decided/finalized; success ⇔ {ACCEPTED, FINALIZED} ∧ FinishedWithReturn
  • verification → fee-config hash for snap cross-check

Pairs with the React/Vue adapters PR (structural typing — no runtime coupling). 6 unit tests; workspace builds green.

Framework-agnostic control plane for fee approval and signing (wallet
architecture stage 1 — direct route only; intents/gateway/ERC-7730 are
stage 2):
- createTransactionKit({chain, provider, account}) on top of genlayer-js v2
  (github:genlayerlabs/genlayer-js#v2-dev)
- estimate(preset/overrides[, tx]) -> PolicyQuote with breakdown
  (consensus work / execution budget / message bucket), caps, total
- submit() routes through the injected EIP-1193 provider; the SDK owns
  encoding; evmTxHash captured from the wallet path
- track() polls to decided/finalized with phase updates; success =
  status in {ACCEPTED, FINALIZED} AND FinishedWithReturn
- verification() exposes the fee-config hash for snap/manual cross-check
6 unit tests green; React/Vue adapters consume this API structurally
(separate PR).
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@MuncleUscles, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 24 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c5046d7d-f214-46a8-8feb-5c0409876d82

📥 Commits

Reviewing files that changed from the base of the PR and between 87d9ef1 and 5266185.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (10)
  • .github/scripts/validate-branch-policy.sh
  • .github/workflows/branch-policy.yml
  • .github/workflows/fast-forward-main.yaml
  • .github/workflows/retarget-main-prs.yaml
  • packages/transaction-kit/package.json
  • packages/transaction-kit/src/index.ts
  • packages/transaction-kit/test/index.test.ts
  • packages/transaction-kit/tsconfig.json
  • packages/transaction-kit/vitest.config.ts
  • support/ci/ACTIVE_DEV_BRANCH
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/transaction-kit-core

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MuncleUscles

Copy link
Copy Markdown
Member Author

Moved to the dedicated repo: https://github.com/genlayerlabs/genlayer-transaction-kit (packages/core). The kit now lives there as @genlayer/transaction-kit with React/Vue adapters as sibling workspaces, styled to the GenLayer design system. Closing in favor of that repo.

@MuncleUscles
MuncleUscles deleted the feat/transaction-kit-core branch June 10, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant