Conversation
…ewards rename genlayer-consensus renames `ValidatorStake.live` to `hasUnclaimedRewards` (the flag marks unclaimed inflation rewards, not node liveness). Update the staking ABI tuple, the `ValidatorView` types and the view mapper, and the fixtures/smoke assertion that read the old key. Depends-On: genlayerlabs/genlayer-consensus#1403 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KVkzRWuHBntyhom3xqHEAG
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Selected consumer full-E2E cut: genlayer-js #220. Frozen direct closure:
All four PRs are mergeable. JS/Python/harness native CI is green; dev-env build/vet/tests pass and it has no native CI workflow. No existing E2E run exists for this consumer cut; its checks are unrequested placeholders. Full scope will use the v0.6 matrix for core components and all configured stacks. This is test qualification only; consensus #1595 and final delivery remain separate. |
|
/run-e2e all |
1 similar comment
|
/run-e2e all |
|
Test only — nothing will merge. |
Delivery context
Handoff from the consensus team. Requested owner: genlayer-js maintainers.
Problem and outcome
genlayer-consensus#1403 renames the
ValidatorStake.livetuple component tohasUnclaimedRewards(the flag marks unclaimed inflation rewards, not node liveness). Named decoding ofvalidatorView*through the ABI shipped here loses thelivekey once the contracts upgrade, soValidatorView.livebecomesundefined.This PR updates the staking ABI tuple (3 components), the
ValidatorViewtypes, the view mapper insrc/staking/actions.ts, and the fixtures/smoke assertion that read the old key. No behavior change.Implementation and validation
npm ci && npx vitest run --typecheck: 13 files, 193 tests passed, no type errors.🤖 Generated with Claude Code
https://claude.ai/code/session_01KVkzRWuHBntyhom3xqHEAG
Integration-cut relationship
The selected M2 landing cut, genlayerlabs/genlayer-consensus#1595, will include this consumer as a dependency. The rename is already in that owner composition. This PR has no reverse consensus dependency, avoiding two competing consensus refs in one resolved E2E closure. No final delivery is authorized by this metadata update.
Green consumer qualification cut
This PR is the current consumer-only full-E2E cut, including Python #116, E2E harness #781 and dev-env #147. Native SDK/harness checks and scoped dev-env validation pass. Core components come from the v0.6 matrix and are resolved to exact SHAs by the App. This run does not qualify the separate consensus #1595 M2 composition; that candidate will receive its own full E2E after current native CI is green. No merge is requested.
Depends-On: genlayerlabs/genlayer-py#116
Depends-On: genlayerlabs/genlayer-e2e#781
Depends-On: genlayerlabs/genlayer-dev-env#147