fix(release): annotate tag so signed-tag config doesn't break make release#41
Merged
Conversation
git tag.gpgsign forces signed/annotated tags and rejects a lightweight 'git tag vX.Y.Z' with 'no tag message?'. Always pass -m; optional MESSAGE="..." appends a release note to the tag subject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
make release VERSION=x.y.zfails at the tag step whentag.gpgsignis enabled:Signed-tag config forces an annotated tag, but the recipe ran a lightweight
git tag vX.Y.Zwith no message. The empty release commit is created first, so the failure leaves a dangling local release commit and no tag.Fix
-m.MESSAGE="..."appends a release note to the tag subject, matching the existingoperator vX.Y.Z: <summary>tag convention.Verified with
make -n; no behavior change when tag signing is off.