fix: avoid leaking mocha types from profiler clock - #1326
Merged
Conversation
commit: |
KuznetsovRoman
commented
Sep 9, 2026
| /** Unix wall-clock timestamp in milliseconds. It is suitable for timestamps shared between processes. */ | ||
| epochNow(): number; | ||
| /** Process CPU usage since startup, or since `previousValue` when it is supplied. */ | ||
| cpuUsage(previousValue?: NodeJS.CpuUsage): NodeJS.CpuUsage; |
Member
Author
There was a problem hiding this comment.
"NodeJS.CpuUsage" causes typescript to add reference to mocha types
Member
There was a problem hiding this comment.
hmmmmmm why is that so, I wonder?
Member
Author
There was a problem hiding this comment.
Because NodeJS is a global namespace, which is expanded by:
@types/node@types/mochaexpect-webdriverio
So all those 3 are referenced
✅ Testplane browser-env run succeed
|
✅ Testplane E2E run succeed
|
shadowusr
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.