Skip to content

fix: proper version format for subsonic ping - #349

Open
FibreTTP wants to merge 1 commit into
gabehf:mainfrom
FibreTTP:subsonic-version-fix
Open

FibreTTP wants to merge 1 commit into
gabehf:mainfrom
FibreTTP:subsonic-version-fix

Conversation

@FibreTTP

Copy link
Copy Markdown

Description

I assume LMS expects the OpenSubsonic version to be 1.x.x, and not a single digit, since OpenSubsonic versions are all in semantic version format. 1.13.0 was chosen because all other uses of the version parameter use 1.13.0.

I don't have Navidrome, so I don't know if this breaks it.

Related Issue(s)

Fixes #211

The other problems in that issue have all already been fixed here or in LMS.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Unit Tests
  • Manual Testing (please describe steps)

Built container with Podman and ran it with my current stable configuration and database (but with the subsonic envs enabled now). Everything works fine.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have ensured my changes generate no new warnings

AI/LLM Usage

  • I disclose that XX% of the code in this PR is written by an LLM. (please estimate)
  • I fully understand all changes made by LLM-generated code.
  • I have not and will not use an LLM to write any part of this PR description or PR comments.

Screenshots (if applicable)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Better support for lms using the Subsonic API

1 participant