Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I assume LMS expects the OpenSubsonic version to be
1.x.x, and not a single digit, since OpenSubsonic versions are all in semantic version format.1.13.0was chosen because all other uses of the version parameter use1.13.0.I don't have Navidrome, so I don't know if this breaks it.
Related Issue(s)
Fixes #211
The other problems in that issue have all already been fixed here or in LMS.
Type of Change
How Has This Been Tested?
Built container with Podman and ran it with my current stable configuration and database (but with the subsonic envs enabled now). Everything works fine.
Checklist
AI/LLM Usage
Screenshots (if applicable)