feat: add common location API contracts - #876
Open
Aniruddha-Shriwant wants to merge 2 commits into
Open
Conversation
| $ref: '#/components/schemas/location_coordinate_in' | ||
| destination_long: | ||
| $ref: '#/components/schemas/location_coordinate_in' | ||
| mode: |
Contributor
There was a problem hiding this comment.
mode needs to be required in this contract. The generated client currently treats it as optional, but the directions endpoint requires callers to send it. Please add mode to the required list and remove default: driving.
Contributor
There was a problem hiding this comment.
required:
- origin_lat
- origin_long
- destination_lat
- destination_long
-
- mode
properties:
mode:
type: string
nullable: true
- default: driving
example: driving
kartikeyrajvaidya
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Autocomplete response requiredness
predictionsandstatusremain required because platform-api's response schema explicitly requires those top-level keys.predictionsis serialized as an unrestricted dictionary (fields.List(fields.Dict())). Platform-api passes through whichever nested keys Google returns; it does not validate, populate, or guarantee keys such asreference,terms,types, orstructured_formatting.secondary_text.null.required. All current recorded fixtures continue to validate.Validation
Clickup
Task link was not provided; repository-check placeholder: https://app.clickup.com/