Skip to content

chore: update fullsend shim workflow#29

Open
fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard
Open

chore: update fullsend shim workflow#29
fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard

Conversation

@fullsend-ai-fullsend

Copy link
Copy Markdown
Contributor

This PR updates the fullsend shim workflow to match the current template in the .fullsend config repo.

The shim content has drifted from the template — this brings it back in sync.

@fullsend-ai-fullsend fullsend-ai-fullsend Bot requested a review from a team as a code owner June 9, 2026 06:46
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 9, 2026

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure · Started 6:48 AM UTC · Completed 6:48 AM UTC
Commit: 9bd7234 · View workflow run →

Update the shim workflow to match the current template
in the .fullsend config repo.
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 10, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:01 PM UTC · Completed 6:08 PM UTC
Commit: fa3e775 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

High

  • [protected-path] .github/workflows/fullsend.yaml — This PR modifies a file under .github/, which is a protected path requiring human approval. The PR has no linked issue justifying the change to governance/infrastructure files. While the change is a trivial 2-line addition (YAML document marker and management comment) from an automated bot, protected-path changes always require explicit human review regardless of scope.
    Remediation: Link an issue documenting the template sync policy and why this protected-path change is authorized, or obtain explicit human approval on this PR.

Low

  • [edge-case] .github/workflows/fullsend.yaml:3 — The # lint-workflow-size: max-lines=280 directive moves from line 1 to line 3 due to the new --- marker and comment. If the linting tool that processes this directive is position-sensitive, the check could silently stop being enforced.

  • [scope-verification] .github/workflows/fullsend.yaml — The PR is labeled as a chore but adds a "do not edit" management comment suggesting automated template management, which may be a structural/process change rather than simple maintenance.

Info

  • [formatting-consistency] .github/workflows/fullsend.yaml:1 — The YAML document start marker --- is not used anywhere else in the repository's YAML files. This may be intentional as part of template sync with the upstream .fullsend config repo.

  • [documentation-pattern] .github/workflows/fullsend.yaml:2 — The "fullsend managed below - do not edit" comment pattern is new to this repository. No other configuration or workflow files use this convention. See also: [architectural-coherence] finding at this location — the managed convention is not documented in project architecture docs.

  • [authorization-inference] .github/workflows/fullsend.yaml — This PR was authored by fullsend-ai-fullsend[bot], suggesting automated template synchronization. The bot's authority and scope are not documented in this repository.

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

@@ -1,3 +1,5 @@
---
# --- fullsend managed below - do not edit ---
# lint-workflow-size: max-lines=280

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] edge-case

The lint-workflow-size: max-lines=280 directive moves from line 1 to line 3 due to the new --- marker and comment. If the linting tool is position-sensitive, the check could silently stop being enforced.

@@ -1,3 +1,5 @@
---

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] formatting-consistency

The YAML document start marker --- is not used anywhere else in the repository YAML files. This may be intentional as part of template sync.

@@ -1,3 +1,5 @@
---
# --- fullsend managed below - do not edit ---

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] documentation-pattern

The fullsend managed below - do not edit comment pattern is new to this repository. No other configuration or workflow files use this convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants