Remove gh auth token doc content anticipated by #207's PR - #211
Merged
Merged
Conversation
PR #209 (closing #207, GCS_DEFAULT_ORG) prematurely documented the GITHUB_TOKEN -> gh auth token fallback that belongs to #208 and hadn't been implemented yet at merge time. Revert those specific mentions from README.md, docs/getting-started/index.md, docs/getting-started/first-search.md and docs/reference/environment.md, keeping only the GCS_DEFAULT_ORG content. PR #210 (closing #208) reintroduces this documentation alongside the actual implementation.
Contributor
|
Coverage after merging fix/remove-anticipated-gh-cli-docs into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation changes are scoped, consistent with the current implementation, and preserve the valid GCS_DEFAULT_ORG content.
Review effort: Lite
Findings: None
What changed in this PR
Removes premature gh auth token fallback documentation so the docs match the current implementation, while preserving the delivered GCS_DEFAULT_ORG guidance.
Changes:
- Removes fallback notes from README and getting-started documentation.
- Removes the fallback section from environment variable reference.
- Restores the prerequisite wording requiring
GITHUB_TOKEN.
| File | Description |
|---|---|
README.md |
Removes premature fallback tip. |
docs/reference/environment.md |
Removes fallback documentation. |
docs/getting-started/index.md |
Removes GitHub CLI setup tip. |
docs/getting-started/first-search.md |
Restores the token prerequisite. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
🔦 Lighthouse Report
|
shouze
added a commit
that referenced
this pull request
Sep 19, 2026
- Restore the exact original 'Error: GITHUB_TOKEN environment variable is not set.' message (unchanged acceptance-criteria contract) instead of replacing it; add the gh CLI hint as a separate dim line. - environment.md: clarify the GITHUB_TOKEN footnote applies to the search commands, and that upgrade never requires a token (uses one only opportunistically for rate limits). - docs/usage/upgrade.md: document the gh auth token fallback for upgrade. - Re-add the 'Already using the GitHub CLI?' tip to docs/getting-started/index.md, silently dropped by an earlier rebase onto main after #211 merged — this is what the prerequisite sentence's 'see below' was supposed to point to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR #209 (closing #207,
GCS_DEFAULT_ORG) prematurely documented theGITHUB_TOKEN→gh auth tokenfallback that belongs to #208 and wasn't implemented yet at merge time. This reverts those specific doc mentions fromREADME.md,docs/getting-started/index.md,docs/getting-started/first-search.mdanddocs/reference/environment.md, keeping only theGCS_DEFAULT_ORGcontent that #207 actually delivered.PR #210 (closing #208) reintroduces this documentation alongside the real implementation, so it lives only where it belongs.
How did you verify your code works?
bun test(1016 passing),bun run lint,bun run format:check,bun run knipall green.bun run docs:buildsucceeds (no dead links).