Repository navigation
Conversation
gdziadkiewicz
requested review from
gdziadkiewicz
and
a balanced review from Copilot
November 12, 2026 22:19
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The tail cannot be safely traversed repeatedly, and source enumerators can leak when the initial read throws or the tail is discarded.
3 open issues
What changed in this PR
This PR updates Seq.tryHeadTail to preserve remaining elements when reading non-rewinding streams in the core collections library.
Changes:
- Uses one enumerator to read the head and lazily produce the tail.
- Adds a regression test verifying that a byte-stream tail includes all remaining bytes.
| File | Description |
|---|---|
tests/FSharpx.Collections.Tests/SeqTests.fs |
Adds byte-stream coverage for tryHeadTail. |
src/FSharpx.Collections/Collections.fs |
Replaces separate head and tail enumeration with a shared enumerator. |
Review effort: Balanced
Comment on lines
+78
to
+79
| if e.MoveNext() then | ||
| let head = e.Current |
|
|
||
| while e.MoveNext() do | ||
| yield e.Current | ||
| } |
| yield e.Current | ||
| } | ||
|
|
||
| Some(head, tail) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.