btc: SERIALIZE macro fix (C2POOL_SERIALIZE_METHODS, PR#71 lockstep) [PR-B/3]#78
Merged
Conversation
PR#71 renamed the macro with no alias; btc/coin + share_types still used the bare name, so READWRITE expanded with formatter/stream/obj out of scope (transaction.hpp:51). Lockstep rename of all 12 sites across 4 files. Fixes the btc compile break; full c2pool-btc link still pending web_server retype.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-B of 3 — btc SERIALIZE macro fix (btc-only)
Renames the single-arg
SERIALIZE_METHODS->C2POOL_SERIALIZE_METHODSin thebtc variant, in lockstep with PR#71 which removed the no-arg alias. Fixes the
btc compile break at
src/impl/btc/coin/transaction.hpp:51; btc now buildsthrough to the LINK stage.
Scope (per-coin isolation invariant)
Touches
src/impl/btc/ONLY — 4 files:src/impl/btc/coin/block.hppsrc/impl/btc/coin/p2p_messages.hppsrc/impl/btc/coin/transaction.hppsrc/impl/btc/share_types.hppNo
src/core, nosrc/impl/ltc. Does NOT make any smoke green on its own:btc smoke is still RED at LINK because
core/web_server.cppis hard-typed toltc::coin::NodeRPC. That is cleared by PR-C (web_server ->core::coin::ICoinNoderetype), which binds to the ltc concrete CoinNode added in PR-A.
Sequence
this branch after PR-A lands on master.
Not requesting a standalone merge; batch with PR-C per integrator.