Repository navigation
refactor(resampling): require explicit max_data_age_in_periods - #1459
Closed
malteschaaf wants to merge 1 commit into
Closed
malteschaaf wants to merge 1 commit into
malteschaaf wants to merge 1 commit into
Conversation
- Remove the 3.0 default from ResamplerConfig and ResamplerConfig2 so apps choose a value consciously and can tune it per site - Pass 3.0 explicitly at all existing call sites to keep current behavior - Document the smoothing vs. responsiveness tradeoff and add upgrade notes Signed-off-by: Malte Schaaf <malte.schaaf@frequenz.com>
github-actions
Bot
added
part:docs
malteschaaf
marked this pull request as draft
September 30, 2026 18:51
llucax
added
the
scope:breaking-change
Contributor
Author
|
Closing this in favour of #1473. Removing the default right away would break every caller at once, so the issue instead suggests changing the defaults only in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the `3.0` default of `max_data_age_in_periods` from `ResamplerConfig` and `ResamplerConfig2`. The value looks rather arbitrary, and by default it makes the resampler smooth over three periods. Following the discussion in #1344, apps should set it explicitly (e.g. via env vars) so we can experiment with it per site before settling on a better value.
All existing call sites now pass `3.0` explicitly, so the behavior doesn't change.