Repository navigation
backport(master): fix(site-backup): Repair a crashed global search table on the site's bench (#7667) - #7716
Conversation
…bench A backup that fails on a crashed __global_search (MyISAM, after an unclean MariaDB stop) should start the agent's Fix global search job. The request had no bench or site, so it hit a path the agent doesn't serve, and the job type had no fixture. Every retry failed the same way. Send it to /benches/<bench>/sites/<site>/fix_global_search (frappe/agent#617) and also match the "marked as crashed" error from any dump query, not only SHOW CREATE TABLE. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit 8cf0f7d)
|
@regdocs, thanks for the contribution, but we do not accept pull requests on a master. Please close this PR and raise PR on an develop branch. |
|
🎉 This PR is included in version 0.155.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (56.75%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #7716 +/- ##
===========================================
- Coverage 86.46% 63.27% -23.20%
===========================================
Files 161 1091 +930
Lines 29870 106637 +76767
Branches 1939 1936 -3
===========================================
+ Hits 25828 67475 +41647
- Misses 3983 39104 +35121
+ Partials 59 58 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Manual backport of #7667 to
master. The automatic backport (#7715) hit a conflict.Cherry-picked commits
Conflicts resolved
press/press/doctype/site_backup/test_site_backup.py, import block: ondevelopthe PR turned the existingalert_if_backup_success_rate_is_lowimport into a multi-line import that also brings inis_global_search_crashed.masterdoesn't havealert_if_backup_success_rate_is_low, so this backport imports onlyis_global_search_crashed.That import line is the only difference from the original PR's diff (test file is +45/-0 here vs +48/-1 on
develop).press/agent.py,press/fixtures/agent_job_type.jsonandsite_backup.pyapplied cleanly and match line for line.🤖 Generated with Claude Code