Skip to content

backport(master): fix(site-backup): Repair a crashed global search table on the site's bench (#7667) - #7716

Merged
regdocs merged 1 commit into
masterfrom
backport/master/pr-7667
Oct 8, 2026
Merged

regdocs merged 1 commit into
masterfrom
backport/master/pr-7667

Conversation

@regdocs

@regdocs regdocs commented Oct 8, 2026

Copy link
Copy Markdown
Member

Manual backport of #7667 to master. The automatic backport (#7715) hit a conflict.

Cherry-picked commits

  • 916be25 (from 8cf0f7d) fix(site-backup): Repair a crashed global search table on the site's bench

Conflicts resolved

  • press/press/doctype/site_backup/test_site_backup.py, import block: on develop the PR turned the existing alert_if_backup_success_rate_is_low import into a multi-line import that also brings in is_global_search_crashed. master doesn't have alert_if_backup_success_rate_is_low, so this backport imports only is_global_search_crashed.

That import line is the only difference from the original PR's diff (test file is +45/-0 here vs +48/-1 on develop). press/agent.py, press/fixtures/agent_job_type.json and site_backup.py applied cleanly and match line for line.

🤖 Generated with Claude Code

…bench

A backup that fails on a crashed __global_search (MyISAM, after an unclean
MariaDB stop) should start the agent's Fix global search job. The request
had no bench or site, so it hit a path the agent doesn't serve, and the job
type had no fixture. Every retry failed the same way.

Send it to /benches/<bench>/sites/<site>/fix_global_search (frappe/agent#617)
and also match the "marked as crashed" error from any dump query, not only
SHOW CREATE TABLE.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 8cf0f7d)
@mergify

mergify Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@regdocs, thanks for the contribution, but we do not accept pull requests on a master. Please close this PR and raise PR on an develop branch.

@regdocs
regdocs merged commit db9e137 into master Oct 8, 2026
6 of 7 checks passed
@regdocs
regdocs deleted the backport/master/pr-7667 branch October 8, 2026 14:39
@frappe-pr-bot

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 0.155.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@codecov-commenter

codecov-commenter commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.75676% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.27%. Comparing base (f00266b) to head (916be25).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ress/press/doctype/site_backup/test_site_backup.py 60.00% 10 Missing ⚠️
press/press/doctype/site_backup/site_backup.py 50.00% 5 Missing ⚠️
press/agent.py 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (56.75%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7716       +/-   ##
===========================================
- Coverage   86.46%   63.27%   -23.20%     
===========================================
  Files         161     1091      +930     
  Lines       29870   106637    +76767     
  Branches     1939     1936        -3     
===========================================
+ Hits        25828    67475    +41647     
- Misses       3983    39104    +35121     
+ Partials       59       58        -1     
Flag Coverage Δ
dashboard 86.47% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants