Repository navigation
feat(dashboard): Announce v16.50 to teams with v16 sites - #7708
Open
balamurali27 wants to merge 7 commits into
Open
balamurali27 wants to merge 7 commits into
balamurali27 wants to merge 7 commits into
Conversation
v16.50 is a large update to v16. Teams with an active v16 site see a banner that links to the release blog until 2026-10-15. The banner is in code, not a Dashboard Banner record. Team scope needs one child row for each team, and that is too many rows. is_global makes the dashboard keep the dismissal in local storage, not in the DB. https://frappe.io/blog/product-updates/announcing-framework-erpnext-and-hrms-v1650 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019oemKXCT6HRQ7cqxinsRUJ
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
After 2026-10-15 the "no v16 site" assertion passed because the banner had expired, not because of the team check. All assertions now run on a fixed date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019oemKXCT6HRQ7cqxinsRUJ
Ubuntu removed redis-server 7.0.15-1ubuntu0.24.04.4 on 2026-10-08 after the .5 security update. The runner image's stale index still asks for .4, so the download 404s and cache-apt-pkgs saves an empty cache. Setup Bench then fails with "redis-server: not found". https://launchpad.net/ubuntu/+source/redis/+publishinghistory Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012dbdqJmSvyS3XntzHbxTaS
UI changes merged without a Playwright test, so a later change could break them with no failing check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019oemKXCT6HRQ7cqxinsRUJ
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7708 +/- ##
============================================
- Coverage 86.62% 63.91% -22.71%
============================================
Files 158 1110 +952
Lines 29818 108270 +78452
Branches 1983 2014 +31
============================================
+ Hits 25829 69205 +43376
- Misses 3932 39006 +35074
- Partials 57 59 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The dashboard calls get_user_banners each time a list or overview page opens, and each call ran the Site and Release Group join. The result is now cached per team for an hour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019oemKXCT6HRQ7cqxinsRUJ
AGENTS.md now asks for a UI test with each UI change. The test mocks get_user_banners, so it does not depend on the date or on v16 sites, and it still passes after the banner end date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019oemKXCT6HRQ7cqxinsRUJ
After the reload, the New Site button could appear before get_user_banners returned. The hidden-banner check then passed even if the dismissal was not kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019oemKXCT6HRQ7cqxinsRUJ
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v16.50 is a large update to v16 (blog). This PR shows a dismissible banner to teams with an active site on a Version 16 bench group. The banner links to the blog and stops showing after 2026-10-15.
The banner is in code because a Team-scoped Dashboard Banner record needs one child row for each v16 team.
get_user_bannersadds it to the list it returns. It is markedis_global, so the dashboard keeps the dismissal in local storage and does not calldismiss_banner. Deleteget_v16_50_release_bannerafter the end date.I tested it with a unit test, and with a Playwright run against the real backend: the banner shows on the sites list, "Open help" opens the blog, and after a dismissal the banner stays hidden when the page reloads.
v16-release-banner.test.tscovers the same steps in CI. It mocksget_user_banners, so it does not depend on the date or on v16 sites.🤖 Generated with Claude Code
https://claude.ai/code/session_019oemKXCT6HRQ7cqxinsRUJ