Fix ENVO import, add ORCIDIO#59
Merged
Merged
Conversation
Including individuals in the merged import module causes a bunch of ENVO individuals representing mostly "ecoregions" to be added to FBbi, even though they have nothing to do here.
Add a component containing the ORCIDIO individuals representing the known contributors to the ontology. This requires forcing the ODK to use the latest version of the ODK ROBOT plugin.
We cannot have `$(COMPONENTSDIR)/orcidio.owl` depend on `$(SRCMEREGD)`, because `$(SRCMERGED)` itself is dependent on all the components. We work around the issue by manually remove all import declarations from the edit file (what is normally done for `$(SRCMERGED)`), _without_ re-adding the import declarations for ODK-declared components (which is what causes the circular dependency). This work in our case because orcidio is the only component in FBbi. Hopefully by the time we add other components to FBbi (if we ever do that), ODK 1.7 will be out and will no longer need to do any of that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: