Repository navigation
fix: render options in linear time in the static HTML renderer - #664
Merged
Merged
Conversation
Contributor
Bundle sizeGzipped size of the entry points on this pull request against its base. Growth over 512 B needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering a field with N options was quadratic. A radio field with 10,000 options took about 1.4 s in goja.
Causes:
html()built its children string with+=in a loop (markup.ts). goja copies the whole string on each append, so allocation grew with N squared.firstOpen()rescanned the options for every option (choices.ts). WithreadOnlyand no selection this is O(N^2) in Node too (6.5 s at 10,000).defaultValuewere checked withincludesper option (choices.ts,warnings.ts).indexOfper option (definition-validation/fields.ts). This also speeds upcheckDefinition().Output is byte-identical to 1.12.0 on 570 renders (templates, fixtures, conformance scenarios, generated option-heavy fields).
Tests count array scan work at 200 and 800 options and assert near-linear growth (fails on main). No timing assertions.
Render time, goja / Node: