Add indexed rotate operators#629
Open
filipeom wants to merge 1 commit into
Open
Conversation
filipeom
force-pushed
the
filipe/fix-rotate-ops
branch
from
0d4e1ea to
04eec15
Compare
Contributor
|
Do you think it makes sense to try using In the Z3 case, it might be faster, and in the others, it may allow to have a partial implementation in some cases? |
Member
Author
Ah good point! Yes I think it is totally worth it 😄 |
filipeom
force-pushed
the
filipe/fix-rotate-ops
branch
3 times, most recently
from
3ca1767 to
e6ad544
Compare
This is needed because some solvers may follow the SMT-LIB standard strictly and only implement the rotate operators using indicies. Closes #625 Closes #627 BREAKING: This change intentionally breaks the `rotate_{left,right}` operators to take an integer as the first argument. This is to force users to make a decision on whether to continue using the previous behavior with `ext_rotate_{left,right}` or start using the new API.
filipeom
force-pushed
the
filipe/fix-rotate-ops
branch
from
e6ad544 to
c12fe2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed because some solvers may follow the SMT-LIB standard strictly and only implement the rotate operators using indicies.
Closes #625
Closes #627
BREAKING: This change intentionally breaks the
rotate_{left,right}operators to take an integer as the first argument. This is to force users to make a decision on whether to continue using the previous behavior withext_rotate_{left,right}or start using the new API.