Skip to content

fix(compiler): reuse the typed loop bindings when rebuilding locals - #180

Merged
skydread1 merged 3 commits into
flybot-sg:developfrom
parth-io:fix/loop-widening-duplicate-typebuilder
Sep 17, 2026
Merged

skydread1 merged 3 commits into
flybot-sg:developfrom
parth-io:fix/loop-widening-duplicate-typebuilder

Conversation

@parth-io

Copy link
Copy Markdown
Collaborator

Closes #179

  • The :loop typed pass rebuilt its locals map by re-running update-bindings, which re-entered analyze-fn and declared a second TypeBuilder nothing ever completed, so AssemblyBuilder.Save threw. It now folds the already-typed bindings instead.
  • CljPluginConstraints drops the retired dual package's editor-exclusion restore.

…179)

Inferring a wider `loop` binding type re-ran `update-bindings` over
already typed bindings to rebuild the `locals` map.

The map is now updated from the bindings directly.
@flybot-sg flybot-sg deleted a comment from parth-io Sep 17, 2026
@skydread1
skydread1 merged commit 9ec3e7f into flybot-sg:develop Sep 17, 2026
1 check passed
@parth-io
parth-io deleted the fix/loop-widening-duplicate-typebuilder branch September 17, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loop/recur creates extraneous TypeBuilders in the case of type widening.

2 participants