Skip to content

Stop using remaining_jobs and failed_jobs and use jobs statuses instead - #5165

Open
ievdokdm wants to merge 2 commits into
flutter:mainfrom
ievdokdm:193862-reamining
Open

ievdokdm wants to merge 2 commits into
flutter:mainfrom
ievdokdm:193862-reamining

Conversation

@ievdokdm

@ievdokdm ievdokdm commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Remove remaining_jobs and failed_jobs from presubmit_guards

Remove the remaining_jobs and failed_jobs fields from PresubmitGuard and derive guard status directly from the jobs TaskStatus map instead of maintaining separate counters.

  • Update GuardStatus.calculate to evaluate Iterable (Succeeded if all isSuccess, Failed if any isFailure, otherwise In Progress)
  • Add PresubmitGuard.status getter and drop remainingJobs/failedJobs
  • Update UnifiedCheckRun, LuciBuildService, request handlers, and unit tests

fix: flutter/flutter#193862

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Oct 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the PresubmitGuard and GuardStatus logic to eliminate the redundant tracking of remainingJobs and failedJobs counters, opting instead to dynamically calculate the guard status directly from the individual job statuses. Numerous request handlers, services, and tests have been updated to support this simplified approach. Additionally, three new users were added to the resetFailedCheckRun configuration. No review comments were provided, so there is no feedback to address.

@ievdokdm ievdokdm changed the title 193862 reamining Stop using remaining_jobs and failed_jobs and use jobs statuses instead Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop using remaining_jobs and failed_jobs and use jobs statuses instead

1 participant