Repository navigation
Enforce test exemptions via missing-tests and test-exempt labels - #5164
Open
eyebrowsoffire wants to merge 3 commits into
Open
eyebrowsoffire wants to merge 3 commits into
eyebrowsoffire wants to merge 3 commits into
Conversation
- Apply and update the missing-tests label on PR open, synchronize, and ready_for_review events in app_dart. - Fix fusion file filtering and comment-only needsTests evaluation in checkForTests. - Update the missing-tests bot comment to direct reviewers to area tech leads for test exemptions. - Block autosubmit on PRs with the missing-tests label unless test-exempt or emergency is also applied. Fixes flutter/flutter#193961
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces automated labeling and validation for pull requests missing tests. It adds the missing-tests and test-exempt labels, updates the webhook subscription to handle ready_for_review events, and implements logic in PullRequestManager to apply or remove the missing-tests label and post comments accordingly. Additionally, it introduces a TestExemption validation in auto_submit to block merging of PRs labeled missing-tests unless they are also labeled test-exempt or emergency. A review comment points out a potential runtime exception in PullRequestManager where pr.draft is force-unwrapped with !, suggesting a safer null-aware check instead.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
jtmcdole
reviewed
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#193961