Repository navigation
Add new kevmoo dart skills and grill me skill for feature planning, update existing skills - #94
Conversation
…pdate existing skills
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly expands the Dart skills library by adding new guides for package:checks migration, line length management, test coverage, and a 'grill-me' interview skill. Additionally, it enhances existing guides with 'Discovery' sections that provide specific regex patterns and strategies for identifying technical debt or modernization opportunities. The PR also includes a new coverage interpretation script and an example package. Review feedback correctly identifies pathing errors in the documentation where the directory name .agents was incorrectly referenced as .agent, and missing repository root prefixes in commands and URLs.
|
|
||
| Run it from the project root (adjust path to script as needed): | ||
| ```bash | ||
| dart run .agent/skills/dart-test-coverage/scripts/interpret_coverage.dart .dart_tool/coverage <package_name> |
There was a problem hiding this comment.
The path to the script in the dart run command is incorrect. The directory in the repository is named .agents (plural), but the command uses .agent (singular). Additionally, the path is missing the tool/dart_skills_lint/ prefix required to locate the script from the repository root.
| dart run .agent/skills/dart-test-coverage/scripts/interpret_coverage.dart .dart_tool/coverage <package_name> | |
| dart run tool/dart_skills_lint/.agents/skills/dart-test-coverage/scripts/interpret_coverage.dart .dart_tool/coverage <package_name> |
| [dart-test-fundamentals]: https://github.com/kevmoo/dash_skills/blob/main/.agent/skills/dart-test-fundamentals/SKILL.md | ||
| [dart-matcher-best-practices]: https://github.com/kevmoo/dash_skills/blob/main/.agent/skills/dart-matcher-best-practices/SKILL.md |
There was a problem hiding this comment.
The URLs for the related skills are likely broken. They use the singular .agent directory name instead of the plural .agents used in this repository, and they are missing the tool/dart_skills_lint/ path prefix. This will result in 404 errors when following the links on GitHub.
| [dart-test-fundamentals]: https://github.com/kevmoo/dash_skills/blob/main/.agent/skills/dart-test-fundamentals/SKILL.md | |
| [dart-matcher-best-practices]: https://github.com/kevmoo/dash_skills/blob/main/.agent/skills/dart-matcher-best-practices/SKILL.md | |
| [dart-test-fundamentals]: https://github.com/kevmoo/dash_skills/blob/main/tool/dart_skills_lint/.agents/skills/dart-test-fundamentals/SKILL.md | |
| [dart-matcher-best-practices]: https://github.com/kevmoo/dash_skills/blob/main/tool/dart_skills_lint/.agents/skills/dart-matcher-best-practices/SKILL.md |
There was a problem hiding this comment.
These urls resolve and are correct. See kevmoo/dash_skills#17
1 participant
Fixes #93
Pre-launch Checklist
///).