Skip to content

update contributing docs with instructions for how to add a new skill. - #76

Merged
johnpryan merged 1 commit into
flutter:mainfrom
reidbaker:r-contributing-docs-explination
Apr 13, 2026
Merged

johnpryan merged 1 commit into
flutter:mainfrom
reidbaker:r-contributing-docs-explination

Conversation

@reidbaker

Copy link
Copy Markdown
Contributor

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@reidbaker
reidbaker requested a review from johnpryan April 13, 2026 16:07

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CONTRIBUTING.md file to include a new section titled "Adding a New Skill," which provides step-by-step instructions for defining, generating, and validating skills using the project's Dart-based tools. I have no feedback to provide.

Comment thread CONTRIBUTING.md
```
3. **Validate the Skill**: Run the validation tool to ensure it meets the standards:
```bash
dart run tool/generator/bin/skills.dart validate-skill --skill <skill-name> -d tool/dart_skills_lint/skills resources/flutter_skills.yaml

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this run the linter too?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of #71 it does.

@johnpryan
johnpryan merged commit 51daaa3 into flutter:main Apr 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants