Repository navigation
Add try catch around read directories and have new error conditions when files cannot be read, plus test - #75
Merged
reidbaker merged 6 commits intoApr 13, 2026
Conversation
…en files cannot be read, plus test
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the Validator class to handle FileSystemException and other unexpected errors when reading the SKILL.md file, adding specific error IDs for these scenarios. It also introduces a test case for inaccessible files and refactors path construction to use the path package. The review feedback suggests using _getSeverity for the new error types to allow for severity overrides and recommends wrapping the permission-altering logic in tests within a try-finally block to ensure proper cleanup even if assertions fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This better handles when skills are symlinked to directories that may not be accessible
Pre-launch Checklist
///).