Repository navigation
Conversation
One place to run "flutter pub get". Brings up the lower end dart to ^3.10.8, upgrades lints and packages.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the repository to a Dart workspace, incorporating the tool/generator and tool/dart_skills_lint packages. It includes significant dependency updates and an SDK version bump. The review feedback identifies a critical mismatch between the Dart SDK version required by the pubspec.lock (3.11.0) and the pubspec.yaml files (3.10.8). Furthermore, the lock file contains inconsistencies regarding dependency types and missing workspace members, suggesting it needs to be regenerated at the workspace root.
|
Lgtm from @jwren in chat to make skills a workspace. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request configures a Dart workspace and applies extensive formatting updates across the dart_skills_lint package and its tests. The review feedback identifies a few missed opportunities in entry_point.dart to apply consistent multi-line formatting to command-line parser options and flags, which would improve overall readability.
| abbr: 's', | ||
| help: 'Path to an individual skill directory to validate. Can be specified multiple times.', | ||
| ) | ||
| ..addOption(_ignoreFileOption, help: 'Path to a JSON file listing lints to ignore for the run.') |
There was a problem hiding this comment.
The addOption call for _ignoreFileOption is missing the consistent multi-line formatting applied to other parser configuration calls in this block, which reduces readability.
| ..addOption(_ignoreFileOption, help: 'Path to a JSON file listing lints to ignore for the run.') | |
| ..addOption( | |
| _ignoreFileOption, | |
| help: 'Path to a JSON file listing lints to ignore for the run.', | |
| ) |
| ..addFlag(_fixFlag, negatable: false, help: 'Preview fixes for failing lints (dry run).') | ||
| ..addFlag(_fixApplyFlag, negatable: false, help: 'Apply fixes for failing lints.') |
There was a problem hiding this comment.
The addFlag calls for _fixFlag and _fixApplyFlag are missing the consistent multi-line formatting applied to other parser configuration calls in this block, which reduces readability.
| ..addFlag(_fixFlag, negatable: false, help: 'Preview fixes for failing lints (dry run).') | |
| ..addFlag(_fixApplyFlag, negatable: false, help: 'Apply fixes for failing lints.') | |
| ..addFlag( | |
| _fixFlag, | |
| negatable: false, | |
| help: 'Preview fixes for failing lints (dry run).', | |
| ) | |
| ..addFlag( | |
| _fixApplyFlag, | |
| negatable: false, | |
| help: 'Apply fixes for failing lints.', | |
| ) |
2 participants
One place to run "flutter pub get".
Brings up the lower end dart to ^3.10.8, upgrades lints and packages.
Pre-launch Checklist
///).