release: Fleet-Ops v0.6.66

RELEASE.md

@@ -1,15 +1,20 @@
-> v0.6.65 ~ "First-class trailer operations"
+> v0.6.66 ~ "Inspections"
 
 ---
 ## What's New
-- **Trailers become a first-class Fleet-Ops resource.** Create and manage trailers independently, attach them to vehicles, connect equipment and telematics devices, and review operational, maintenance, location, and towing details from dedicated Trailer screens.
-- **Vehicle and equipment relationships are easier to understand.** Vehicle details expose attached trailers and equipment, while Trailer details show the current towing vehicle and installed equipment.
-- **Trailer APIs support complete integrations.** Internal and public endpoints cover trailer lifecycle, filtering, towing connections, equipment, devices, telemetry, imports, and exports.
+- **Inspection forms are built from typed fields.** A form is groups of fields laid out on a grid: pass/fail checks with severity and on-fail settings, text, numbers, selections, dates, photo uploads and signatures. Forms are built and published from a form builder in the console.
+- **One inspection sheet everywhere.** The same sheet is used to fill in an inspection in the console, to read one back, and on a public link. A failed check opens its severity, unsafe flag, comment and photos in place, and a defects tray summarises what needs attention. It works on phones and tablets.
+- **Drivers file inspections through the API.** The `v1` inspection endpoints list published forms, file an inspection against one, and read back submissions and a vehicle's history, for the Navigator app and other integrations.
+- **Inspection links for anyone in the organisation.** A link can be assigned to any user, protected by a six-digit PIN, and emailed or texted to them. A failed inspection can raise an issue and open a work order, and every submission records who filed it.
+
+---
+## Fixes
+- Place, zone and service area details, and the place and point map modals, no longer fail to render with "A resolved helper cannot be passed as a named argument".
 
 ---
 ## Testing
-- Added frontend, backend, API-contract, attachment, telematics, spatial-data, permission, and serialization coverage for first-class trailers.
-- Expanded the Fleetbase Postman collection and documentation alongside the Fleet-Ops implementation.
+- Model and controller contract tests cover inspection forms, submissions, links and the PIN lockout.
+- The Fleetbase Postman collection documents the `v1` inspection endpoints.
 
 ---
 ## Need help?

addon/components/inspection-field/form.hbs

@@ -0,0 +1,103 @@
+<div class="inspection-field-form space-y-3" ...attributes>
+    <InputGroup @name={{t "inspection.field.label"}}>
+        <input type="text" value={{this.field.label}} class="w-full form-input" placeholder={{t "inspection.field.label-placeholder"}} disabled={{this.isDisabled}} {{on "input" this.setLabel}} />
+    </InputGroup>
+
+    <InputGroup @name={{t "inspection.field.name"}} @helpText={{t "inspection.field.name-help"}}>
+        <input type="text" value={{this.field.name}} class="w-full form-input font-mono" placeholder={{t "inspection.field.name-placeholder"}} disabled={{this.isDisabled}} {{on "input" this.setName}} />
+    </InputGroup>
+
+    <InputGroup @name={{t "inspection.field.type"}}>
+        <select class="form-select w-full" disabled={{this.isDisabled}} {{on "change" this.setType}}>
+            {{#each this.fieldTypes as |fieldType|}}
+                <option value={{fieldType}} selected={{eq this.field.type fieldType}}>
+                    {{t (concat "inspection.field-type." fieldType)}}
+                </option>
+            {{/each}}
+        </select>
+    </InputGroup>
+
+    <InputGroup @name={{t "inspection.field.description"}}>
+        <textarea class="w-full form-input" rows="2" placeholder={{t "inspection.field.description-placeholder"}} disabled={{this.isDisabled}} {{on "input" this.setDescription}}>{{this.field.description}}</textarea>
+    </InputGroup>
+
+    <InputGroup @name={{t "inspection.field.help-text"}}>
+        <input type="text" value={{this.field.help_text}} class="w-full form-input" placeholder={{t "inspection.field.help-text-placeholder"}} disabled={{this.isDisabled}} {{on "input" this.setHelpText}} />
+    </InputGroup>
+
+    <div class="flex flex-col space-y-3">
+        <Toggle @isToggled={{this.field.required}} @onToggle={{this.setRequired}} @label={{t "inspection.field.required"}} @disabled={{this.isDisabled}} />
+        <Toggle @isToggled={{this.field.editable}} @onToggle={{this.setEditable}} @label={{t "inspection.field.editable"}} @disabled={{this.isDisabled}} />
+    </div>
+
+    {{#if this.hasOptions}}
+        <InputGroup @name={{t "inspection.field.options"}}>
+            <div class="space-y-2">
+                {{#each this.options as |option index|}}
+                    <div class="flex flex-row items-center space-x-2">
+                        <input type="text" value={{option}} class="w-full form-input" disabled={{this.isDisabled}} {{on "input" (fn this.updateOption index)}} />
+                        <Button @type="danger" @icon="trash" @size="xs" @disabled={{this.isDisabled}} @onClick={{fn this.removeOption index}} />
+                    </div>
+                {{else}}
+                    <div class="text-xs text-gray-500">{{t "inspection.field.no-options"}}</div>
+                {{/each}}
+                <div class="flex flex-row items-center space-x-2">
+                    <input type="text" value={{this.newOption}} class="w-full form-input" placeholder={{t "inspection.field.option-placeholder"}} disabled={{this.isDisabled}} {{on "input" this.setNewOption}} />
+                    <Button @icon="plus" @size="xs" @text={{t "inspection.field.add-option"}} @disabled={{this.isDisabled}} @onClick={{this.addOption}} />
+                </div>
+            </div>
+        </InputGroup>
+    {{/if}}
+
+    {{#if this.isNumber}}
+        <InputGroup @name={{t "inspection.field.unit"}} @helpText={{t "inspection.field.unit-help"}}>
+            <input type="text" value={{this.meta.unit}} class="w-full form-input" placeholder={{t "inspection.field.unit-placeholder"}} disabled={{this.isDisabled}} {{on "input" this.setUnit}} />
+        </InputGroup>
+        <Toggle @isToggled={{this.isOdometer}} @onToggle={{this.toggleOdometerRole}} @label={{t "inspection.field.odometer-role"}} @helpText={{t "inspection.field.odometer-role-help"}} @disabled={{this.isDisabled}} />
+    {{/if}}
+
+    {{#if this.isPassFail}}
+        <div class="rounded-lg border border-gray-200 dark:border-gray-700 p-3 space-y-3">
+            <div class="text-xs font-semibold uppercase tracking-wide text-gray-500">{{t "inspection.field.on-fail"}}</div>
+            <div class="text-xs text-gray-500">{{t "inspection.field.on-fail-help"}}</div>
+
+            <InputGroup @name={{t "inspection.field.default-severity"}}>
+                <div class="fleetbase-model-select fleetbase-power-select ember-model-select">
+                    <PowerSelect
+                        @options={{this.severityOptions}}
+                        @selected={{this.meta.severity}}
+                        @onChange={{this.setSeverity}}
+                        @triggerClass="form-select form-input"
+                        @renderInPlace={{true}}
+                        @disabled={{this.isDisabled}}
+                        as |severity|
+                    >
+                        {{t (concat "inspection.severity." severity)}}
+                    </PowerSelect>
+                </div>
+            </InputGroup>
+
+            <Toggle @isToggled={{this.meta.require_photo_on_fail}} @onToggle={{this.setRequirePhotoOnFail}} @label={{t "inspection.field.require-photo-on-fail"}} @disabled={{this.isDisabled}} />
+            <Toggle @isToggled={{this.meta.require_comment_on_fail}} @onToggle={{this.setRequireCommentOnFail}} @label={{t "inspection.field.require-comment-on-fail"}} @disabled={{this.isDisabled}} />
+            <Toggle @isToggled={{this.meta.unsafe_on_fail}} @onToggle={{this.setUnsafeOnFail}} @label={{t "inspection.field.unsafe-on-fail"}} @helpText={{t "inspection.field.unsafe-on-fail-help"}} @disabled={{this.isDisabled}} />
+
+            <InputGroup @name={{t "inspection.field.instructions"}}>
+                <textarea class="w-full form-input" rows="3" placeholder={{t "inspection.field.instructions-placeholder"}} disabled={{this.isDisabled}} {{on "input" this.setInstructions}}>{{this.meta.instructions}}</textarea>
+            </InputGroup>
+        </div>
+    {{/if}}
+
+    <InputGroup @name={{t "inspection.field.column-span"}}>
+        <div class="flex flex-row items-center space-x-2">
+            {{#each this.colSpanOptions as |size|}}
+                <Button
+                    @type={{if (eq this.meta.colSpan size) "primary" "default"}}
+                    @size="xs"
+                    @text={{size}}
+                    @disabled={{this.isDisabled}}
+                    @onClick={{fn this.setColSpan size}}
+                />
+            {{/each}}
+        </div>
+    </InputGroup>
+</div>

addon/components/inspection-field/form.js

@@ -0,0 +1,211 @@
+import Component from '@glimmer/component';
+import { tracked } from '@glimmer/tracking';
+import { action } from '@ember/object';
+import { INSPECTION_FIELD_TYPES, INSPECTION_SEVERITIES, componentForFieldType, isOptionFieldType } from '../../utils/inspection-field-types';
+
+/**
+ * The editor for one inspection field.
+ *
+ * It is the platform's custom-field editor plus what an inspection needs: the
+ * eleven types an inspection form may be built from, and — only for
+ * `pass-fail` — the *On fail* rules the driver app enforces and the server
+ * re-checks (`InspectionSubmitter::normalizeValue()`).
+ *
+ * The field is a plain object owned by the builder's draft, not an Ember Data
+ * record: a form is laid out before the form record exists and the whole
+ * structure is written on the first save. Nothing here mutates `@field` — each
+ * change builds a new object and hands it to `@onChange`, so no write ever
+ * happens during render.
+ */
+export default class InspectionFieldFormComponent extends Component {
+    @tracked newOption = '';
+
+    fieldTypes = INSPECTION_FIELD_TYPES;
+    severityOptions = INSPECTION_SEVERITIES;
+    colSpanOptions = [1, 2, 3];
+
+    /**
+     * The field being edited, held locally so an edit re-renders.
+     *
+     * Invoked directly by the builder the field arrives as `@field`; rendered
+     * inside the resource context panel it arrives on the overlay
+     * definition's shared `state`, which is a plain object — mutating it
+     * would never re-render, so the component owns a tracked copy and writes
+     * through on every change. That shared handle is what the builder reads
+     * back when the author saves.
+     */
+    @tracked localField = this.args.field ?? this.args.overlay?.state?.field ?? {};
+
+    get field() {
+        return this.localField;
+    }
+
+    get isDisabled() {
+        return this.args.disabled ?? this.args.overlay?.disabled ?? false;
+    }
+
+    get meta() {
+        const meta = this.field.meta;
+        return meta && typeof meta === 'object' ? meta : {};
+    }
+
+    get isPassFail() {
+        return this.field.type === 'pass-fail';
+    }
+
+    get isNumber() {
+        return this.field.type === 'number';
+    }
+
+    get hasOptions() {
+        return isOptionFieldType(this.field.type);
+    }
+
+    get options() {
+        return Array.isArray(this.field.options) ? this.field.options : [];
+    }
+
+    get isOdometer() {
+        return this.meta.role === 'odometer';
+    }
+
+    /** Every change to the field goes through here, and only from an action. */
+    change(attributes) {
+        const next = { ...this.field, ...attributes };
+        this.localField = next;
+
+        if (this.args.overlay?.state) {
+            this.args.overlay.state.field = next;
+        }
+
+        if (typeof this.args.onChange === 'function') {
+            this.args.onChange(next);
+        }
+    }
+
+    changeMeta(attributes) {
+        this.change({ meta: { ...this.meta, ...attributes } });
+    }
+
+    /**
+     * The name a label derives to. The label names the field; this machine
+     * name follows it until the author types one of their own.
+     *
+     * Not `dasherize`: it only rewrites spaces and underscores, so a label
+     * like "Sidewall condition, offside rear" kept its comma and produced
+     * `sidewall-condition,-offside-rear`. The name is an identifier — it
+     * travels as an item result's `item_key` and is what a report groups on —
+     * so anything that is not a letter or a digit becomes a separator, and
+     * runs of separators collapse.
+     */
+    slugify(value) {
+        return String(value ?? '')
+            .trim()
+            .toLowerCase()
+            .replace(/[^a-z0-9]+/g, '-')
+            .replace(/^-+|-+$/g, '');
+    }
+
+    @action setLabel(event) {
+        const label = event.target.value;
+        const derived = this.slugify(this.field.label);
+        const current = (this.field.name ?? '').trim();
+
+        // The name follows the label until an author types their own.
+        const follows = current === '' || current === derived;
+
+        this.change({
+            label,
+            name: follows ? this.slugify(label) : current,
+        });
+    }
+
+    @action setName(event) {
+        this.change({ name: this.slugify(event.target.value) });
+    }
+
+    @action setDescription(event) {
+        this.change({ description: event.target.value });
+    }
+
+    @action setHelpText(event) {
+        this.change({ help_text: event.target.value });
+    }
+
+    @action setType(event) {
+        const type = event.target.value;
+        const attributes = { type, component: componentForFieldType(type) };
+
+        // A field that has just become pass-fail needs the defaults its rules
+        // are read from; one that has stopped being pass-fail keeps its meta,
+        // because the author may be switching back.
+        if (type === 'pass-fail' && this.meta.severity === undefined) {
+            attributes.meta = { ...this.meta, severity: 'medium', require_photo_on_fail: false, require_comment_on_fail: false, unsafe_on_fail: false };
+        }
+
+        this.change(attributes);
+    }
+
+    @action setRequired(required) {
+        this.change({ required: Boolean(required) });
+    }
+
+    @action setEditable(editable) {
+        this.change({ editable: Boolean(editable) });
+    }
+
+    @action setColSpan(colSpan) {
+        this.changeMeta({ colSpan });
+    }
+
+    @action setUnit(event) {
+        this.changeMeta({ unit: event.target.value });
+    }
+
+    @action toggleOdometerRole(isOdometer) {
+        this.changeMeta({ role: isOdometer ? 'odometer' : null });
+    }
+
+    @action setSeverity(severity) {
+        this.changeMeta({ severity });
+    }
+
+    @action setRequirePhotoOnFail(value) {
+        this.changeMeta({ require_photo_on_fail: Boolean(value) });
+    }
+
+    @action setRequireCommentOnFail(value) {
+        this.changeMeta({ require_comment_on_fail: Boolean(value) });
+    }
+
+    @action setUnsafeOnFail(value) {
+        this.changeMeta({ unsafe_on_fail: Boolean(value) });
+    }
+
+    @action setInstructions(event) {
+        this.changeMeta({ instructions: event.target.value });
+    }
+
+    @action setNewOption(event) {
+        this.newOption = event.target.value;
+    }
+
+    @action addOption() {
+        const option = this.newOption.trim();
+        if (option === '') {
+            return;
+        }
+
+        this.newOption = '';
+        this.change({ options: [...this.options, option] });
+    }
+
+    @action updateOption(index, event) {
+        const value = event.target.value;
+        this.change({ options: this.options.map((option, optionIndex) => (optionIndex === index ? value : option)) });
+    }
+
+    @action removeOption(index) {
+        this.change({ options: this.options.filter((_, optionIndex) => optionIndex !== index) });
+    }
+}