Skip to content

[codex] open guide GitHub link safely#686

Open
Sean-Kenneth-Doherty wants to merge 1 commit into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/open-guide-tldr-link-safely
Open

[codex] open guide GitHub link safely#686
Sean-Kenneth-Doherty wants to merge 1 commit into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/open-guide-tldr-link-safely

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

Summary

  • make the guide page TL;DR GitHub link open like a safe external link
  • add rel="noopener noreferrer" alongside target="_blank"
  • keep the change scoped to the standalone guide page copy

Validation

  • ran git diff --check
  • ran GITHUB_TOKEN=$(gh auth token) pnpm build
  • checked dist/contribute-to-opensource/index.html renders the TL;DR GitHub link with target="_blank" and rel="noopener noreferrer"

Refs #347
Refs #501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant