Skip to content

Feature/dark mode source only#651

Open
Vishnu912py wants to merge 2 commits into
firstcontributions:mainfrom
Vishnu912py:feature/dark-mode-source-only
Open

Feature/dark mode source only#651
Vishnu912py wants to merge 2 commits into
firstcontributions:mainfrom
Vishnu912py:feature/dark-mode-source-only

Conversation

@Vishnu912py
Copy link
Copy Markdown

No description provided.

- Add DarkModeToggle component with sun/moon icons
- Update all components to support light/dark themes
- Add CSS custom properties for theme switching
- Implement persistent theme preference storage
- Add smooth transitions between themes
@Sean-Kenneth-Doherty
Copy link
Copy Markdown

Thanks for splitting this into a source-only PR. I rechecked head 1cce212; it is closer, but a few blockers remain:

  • The PR still includes generated Astro cache files: .astro/data-store.json, .astro/settings.json, and .astro/types.d.ts. Please restore/remove those from the branch.
  • git diff --check origin/main...HEAD still fails on trailing whitespace in src/components/DarkModeToggle.astro lines 27 and 31.
  • GITHUB_TOKEN=... pnpm build completes, but Vite/esbuild warns about malformed CSS: box-shavar(--text-primary), backgrovar(--text-secondary), and color: var(--text-primary)t.
  • Those CSS issues are visible in source at src/components/IssueList.astro lines 224, 261, 300, and 307. src/components/ProjectCard.astro line 166 also has an incomplete margin:var(--text-secondary declaration.

Suggested next step: remove the .astro files from the PR and repair those CSS typos before another build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants