Skip to content

[codex] open get started guide safely#645

Open
Sean-Kenneth-Doherty wants to merge 1 commit into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/open-get-started-in-new-tab
Open

[codex] open get started guide safely#645
Sean-Kenneth-Doherty wants to merge 1 commit into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/open-get-started-in-new-tab

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

Summary

  • make the external Get started CTA open in a new tab like the other off-site links
  • add rel="noopener noreferrer" to the GitHub guide link

Refs #501
Refs #347

Validation

  • GITHUB_TOKEN=$(gh auth token) pnpm build
  • confirmed generated dist/index.html renders the LinkButton anchor with target="_blank" and rel="noopener noreferrer"
  • git diff --check main...HEAD

@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Validated this head in a detached scratch worktree (e4d7fd74783cbcb4c7bc7e3fdf434acd51a34a44).

Commands/checks run:

GITHUB_TOKEN=$(gh auth token) pnpm build
rg -n '<a class="LinkButton" href="https://github.com/firstcontributions/first-contributions/blob/main/README.md" target="_blank" rel="noopener noreferrer"' dist/index.html
git diff --check

Result: pnpm build completed successfully, the generated homepage renders the Get started LinkButton with target="_blank" and rel="noopener noreferrer", and git diff --check was clean.

@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Fresh validation against the current PR head (e4d7fd7):

  • GITHUB_TOKEN=$(gh auth token) pnpm build -> Astro build succeeded, 2 pages
  • confirmed generated dist/index.html renders the Get started LinkButton anchor with target="_blank"
  • confirmed the same anchor includes rel="noopener noreferrer"
  • git diff --check origin/main...HEAD -> clean

Generated .astro/dist output was restored after validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant