Skip to content

[codex] honor homepage search query#643

Open
Sean-Kenneth-Doherty wants to merge 1 commit into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/honor-homepage-search-query
Open

[codex] honor homepage search query#643
Sean-Kenneth-Doherty wants to merge 1 commit into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/honor-homepage-search-query

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty commented May 17, 2026

Summary

  • initialize the project search box from the homepage q query parameter
  • let the existing client-side filter apply immediately on page load
  • show an accessible no-results status message when a query or filter hides every project
  • make the published structured search URL return filtered project results instead of ignoring the query

Refs #348
Refs #501

Validation

  • GITHUB_TOKEN=$(gh auth token) pnpm build
  • executed the generated module script against a fake DOM: ?q=react seeds the input and filters 152 cards to 17 visible with the no-results message hidden; a no-match query filters 152 cards to 0 visible and shows the no-results message
  • confirmed generated dist/index.html includes role="status" and aria-live="polite" on the no-results message
  • git diff --check

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty force-pushed the codex/honor-homepage-search-query branch from 63827ab to 967ebae Compare May 17, 2026 04:24
@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Validated this head in a detached scratch worktree (967ebae42fe60e70fd9783b58cc17db4c2a8e87d).

Commands/checks run:

GITHUB_TOKEN=$(gh auth token) pnpm build
node --input-type=module   # exercised the ProjectList script against a fake DOM
git diff --check

Result: pnpm build completed successfully. The fake-DOM check loaded the same 152 projects used by the page: ?q=react seeded the search input and filtered the list to 17 visible cards with the no-results message hidden; a no-match query filtered to 0 visible cards and made the no-results message visible. git diff --check was clean.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty force-pushed the codex/honor-homepage-search-query branch from 967ebae to 833bd61 Compare May 17, 2026 04:34
@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Fresh validation against the current PR head (833bd61):

  • GITHUB_TOKEN=$(gh auth token) pnpm build -> Astro build succeeded, 2 pages
  • executed the generated ProjectList module script against a fake DOM loaded with the 152 current projects
  • ?q=react seeded the search input, filtered to 17 visible cards, and kept the no-results message hidden
  • a no-match query filtered to 0 visible cards and made the no-results message visible
  • confirmed generated dist/index.html includes role="status" and aria-live="polite" on the no-results message
  • git diff --check origin/main...HEAD -> clean

Generated .astro/dist output was restored after validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant