LLMQ: bound locked transaction requests

[navidR]

Limit locked-transaction requests to four suitable peers and use the correct inventory mutex. Add focused coverage for peer selection, masternode preference, and cleanup.

Upstream: Dash PR #4680 and Dash PR #4203.

[coderabbitai]

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c81d7470-b5fa-4642-8bd1-492f86b885ea

📥 Commits

Reviewing files that changed from the base of the PR and between 4f0c771 and 9eac7ce.

📒 Files selected for processing (4)

• src/llmq/quorums_instantsend.cpp
• src/llmq/quorums_instantsend.h
• src/test/CMakeLists.txt
• src/test/quorums_instantsend_request_tests.cpp

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-08-30T14:59:17.648188Z	9eac7ce	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[codeant-ai]

🤖 CodeAnt AI — Review Status

Status	Commit	Started (UTC)	Finished (UTC)
✅ Reviewed your PR	9eac7ce	Aug 30, 2026 · 14:56	14:59

[codeant-ai]

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[codeant-ai]

User description

Limit locked-transaction requests to four suitable peers and use the correct inventory mutex. Add focused coverage for peer selection, masternode preference, and cleanup.

---

CodeAnt-AI Description

Bound InstantSend requests and prioritize masternode peers

What Changed

• InstantSend requests for a locked transaction now go to at most four peers that already know the transaction
• Masternode peers are selected before regular peers
• Added coverage for the four-peer limit, peer preference, inventory tracking, and request cleanup

Impact

✅ Fewer unnecessary peer requests
✅ Faster locked-transaction recovery from masternodes
✅ Lower network overhead

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9eac7ce259

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Count only peers that accept the request

When any of the first four candidates has an over-limit vecAskFor or setAskFor—for example, after an inventory flood—CNode::AskFor returns without queuing anything (src/net.cpp:3568-3579), but this peer has already consumed one of the four vector slots. Since subsequent eligible peers are skipped once the vector reaches four, recovery can enqueue fewer than four, or even zero, requests and never ask an available fifth peer for the locked transaction; continue selecting until four requests are actually accepted.

AGENTS.md reference: AGENTS.md:L238-L238

Useful? React with 👍 / 👎.

[reubenyap]

Reviewed peer selection end to end, including connection lifetime/ref-counting, the inventory lock, masternode-first ordering, request cleanup, and the focused boundary test. The four-peer cap is enforced without dropping the preferred eligible peers; CI is green, and I found no new actionable defects.