Qt: Refresh GUI translation source catalog - #1928
Conversation
Restore malformed rich text and placeholders, and replace a blank Ping label.
Pass source paths through an xgettext response file to stay within Windows command-line limits. Stop before replacing the generated catalog when extraction fails.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
User descriptionPR intentionRepair and refresh the Qt translation source catalog for the UI redesign. The extractor still emitted This is a prerequisite for native-language translation work. It does not claim that the 85 non-English catalogs are complete. Related to #1914. Code changes brief
Validation:
Known limitation: Localized coverage remains 31,088 of 129,625 source-language pairs (23.98%), leaving 98,537 untranslated pairs. Accurate completion requires a Firo-owned localization workflow and native review. This draft is stacked on CodeAnt-AI DescriptionRefresh Qt translations for the redesigned Firo wallet and Spark features What Changed
Impact
💡 Usage GuideChecking Your Pull RequestEvery time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later. Talking to CodeAnt AIGot a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask: This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code. ExamplePreserve Org Learnings with CodeAntYou can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input: This helps CodeAnt AI learn and adapt to your team's coding style and standards. ExampleRetrigger reviewAsk CodeAnt AI to review the PR again, by typing: Check Your Repository HealthTo analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health. |
CodeAnt Nitpicks5 code suggestions1. The translation omits the space after the first sentence, causing the displayed Persian text to run together at the sentence boundary.Possible bug · 2. Spaces inside the second bold tag become visible around the emphasized phrase, adding unintended whitespace to this rich-text guidance.Possible bug · 3. The singular form renders
|
PR intention
Repair and refresh the Qt translation source catalog for the UI redesign. The extractor still emitted
bitcoin-corewhile the application and catalogs usefiro-core, and its CMake invocation omitted Firo package metadata. The checked-in English source catalog also missed current redesign and Spark strings.This is a prerequisite for native-language translation work. It does not claim that the 85 non-English catalogs are complete. Related to #1914.
Code changes brief
firo-coreand pass Firo package and copyright metadata.bitcoinstrings.cppandbitcoin_en.tsfrom the currentui-redesignsources, yielding 1,525 source messages.%nplaceholders, a blank ChinesePinglabel, and an Estonian typo.Validation:
lupdate: 1,525 existing messages, 0 new, byte-identical English catalog.lrelease: 86/86 catalogs compiled with zero failures. Four untouched catalogs emit pre-existing plural-form notices.git diff --check origin/ui-redesign...HEADpassed.Known limitation:
Localized coverage remains 31,088 of 129,625 source-language pairs (23.98%), leaving 98,537 untranslated pairs. Accurate completion requires a Firo-owned localization workflow and native review. This draft is stacked on
ui-redesign, so the normal PR workflow that targetsmasterwill not run until this is retargeted after #1914 merges.