more petsc4py fixes - #5464
Merged
Merged
more petsc4py fixes#5464
Conversation
connorjward
enabled auto-merge (squash)
September 17, 2026 15:17
connorjward
previously approved these changes
Sep 17, 2026
connorjward
approved these changes
Sep 17, 2026
Contributor
|
Merging despite the single test failure because it's a critical fix. One failing test is much less problematic than firedrake-check failing. |
Contributor
That failure was introduced after merging firedrakeproject/fiat#240, and should go away with #4994. I only learned about the petsc4py failures mid-merge, so I was waiting for this before merging the firedrake counterpart (which passes this test). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.