Conversation
Replace bare `iptables` commands in the network setup section of getting-started.md with dual `nft` (recommended) and `iptables-nft` alternatives, consistent with the pattern in docs/network-setup.md. Also replace `sudo sh -c "echo 1 > /proc/..."` with the safer `echo 1 | sudo tee /proc/...` form. Closes firecracker-microvm#4874 (Part A)
|
Hey @AdaAibaby, thanks for the contribution! What is the goal with this change? Did you find any issues with the current getting started guide? I think we should keep it as simple as possible for new people to use the guide and defer to the specific documentation for different set ups. |
Hi @Manciukic, thanks for the quick look, and I fully agree the getting-started guide should stay as simple as possible. The motivation isn't to add options for their own sake — it's that the current guide uses bare iptables, which is exactly what #4874 is tracking for removal. On recent distros (current Ubuntu/Debian/Fedora) the legacy iptables backend is That said, your simplicity point is well taken. I'm happy to trim this down so getting-started shows only the recommended nft path (a single, clean block), and we defer the iptables-nft alternative to network-setup.md where the detailed Want me to push that simpler single-path version? |
Summary
Replace bare
iptablescommands indocs/getting-started.mdwith dualnft(recommended) andiptables-nftalternatives, consistent with thepattern already established in
docs/network-setup.md.both
nftandiptables-nftoptions as separate, labelled sectionssudo sh -c "echo 1 > /proc/sys/net/ipv4/ip_forward"withecho 1 | sudo tee /proc/sys/net/ipv4/ip_forward(safer, consistentwith network-setup.md)
iptablespattern;nfttable/chain creation handles fresh setup cleanly
Fixes #4874 (Part A:
docs/getting-started.md)Hi @Manciukic @JackThomson2 @kanpov , this PR addresses part of #4874 (getting-started docs migration to nft/iptables-nft). Would you mind taking a look when you have a chance? Thanks!