[blk-threaded - 3/5] seccomp: add block worker thread filter - #6131
Open
PierreBertholom wants to merge 4 commits into
Open
PierreBertholom wants to merge 4 commits into
PierreBertholom wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pbertho/blk-threaded-04 #6131 +/- ##
===========================================================
- Coverage 82.40% 82.40% -0.01%
===========================================================
Files 278 278
Lines 31965 31979 +14
===========================================================
+ Hits 26342 26353 +11
- Misses 5623 5626 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Manciukic
reviewed
Aug 26, 2026
PierreBertholom
force-pushed
the
pbertho/blk-threaded-09
branch
from
September 9, 2026 10:06
e3a30b2 to
db91c53
Compare
PierreBertholom
requested review from
marco-marangoni and
micz010
as code owners
September 9, 2026 10:06
PierreBertholom
removed this pull request from stack #6135
September 9, 2026 10:07
PierreBertholom
changed the base branch from
pbertho/blk-threaded-08
to
pbertho/blk-threaded-04
September 9, 2026 10:07
PierreBertholom
added this pull request to stack #6198
September 9, 2026 10:08
PierreBertholom
changed the title
PierreBertholom
force-pushed
the
pbertho/blk-threaded-09
branch
from
September 10, 2026 15:24
db91c53 to
df1fc1e
Compare
PierreBertholom
force-pushed
the
pbertho/blk-threaded-09
branch
2 times, most recently
from
September 14, 2026 20:36
4000847 to
76a788d
Compare
PierreBertholom
force-pushed
the
pbertho/blk-threaded-09
branch
from
September 15, 2026 14:35
76a788d to
243c7b1
Compare
PierreBertholom
force-pushed
the
pbertho/blk-threaded-09
branch
from
September 15, 2026 22:51
243c7b1 to
d85ee9d
Compare
PierreBertholom
force-pushed
the
pbertho/blk-threaded-09
branch
from
September 16, 2026 15:05
d85ee9d to
29356b2
Compare
PierreBertholom
force-pushed
the
pbertho/blk-threaded-09
branch
from
September 16, 2026 15:57
29356b2 to
8e2c1ae
Compare
Reset the shared memfd before each export so a shorter filter cannot retain instructions from the previous filter. Signed-off-by: Pierre Bertholom <pbertho@amazon.com>
Resolve x86 syscall numbers written through partial registers while preserving unaffected bits during backpropagation. Inspect seccomp rules from all thread categories. Signed-off-by: Pierre Bertholom <pbertho@amazon.com>
Add an optional seccomp category and a syscall allowlist for block workers. Keep existing custom filters valid when no block worker is needed. Apply the filter before entering the worker event loop. Signed-off-by: Pierre Bertholom <pbertho@amazon.com>
Document the allowed and mandatory Firecracker thread categories. Explain when custom filters need the optional block worker category. Signed-off-by: Pierre Bertholom <pbertho@amazon.com>
PierreBertholom
force-pushed
the
pbertho/blk-threaded-09
branch
from
September 18, 2026 14:46
8e2c1ae to
b8eee34
Compare
ShadowCurse
reviewed
Sep 18, 2026
Comment on lines
+164
to
+165
| memfd.set_len(0).map_err(CompilationError::MemfdTruncate)?; | ||
| memfd.rewind().map_err(CompilationError::MemfdRewind)?; |
Contributor
There was a problem hiding this comment.
heh, this forced me to take another look at this memfd dance we are doing here and as it appears we can just export to the buffer directly so I opened #6234 to fix this. Does not block this PR though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[3/5] part of the PR stack starting with #6123
Add seccomp support for the block worker thread and update the related tools and documentation.
Changes
blk_workercategory.io_uring.