Skip to content

fix(auth): use 127.0.0.1 for OAuth loopback and surface --no-localhost hint #11000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prajeeth-12 wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −2
Open

fix(auth): use 127.0.0.1 for OAuth loopback and surface --no-localhost hint #11000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7221441
fix(auth): use 127.0.0.1 for OAuth loopback and surface --no-localhos…
Prajeeth-12 Aug 29, 2026
90f07f4
fix(auth): clear troubleshooting timeout on server close
Prajeeth-12 Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ function getCallbackUrl(port?: number): string {
if (typeof port === "undefined") {
return "urn:ietf:wg:oauth:2.0:oob";
}
return `http://localhost:${port}`;
return `http://127.0.0.1:${port}`;
}

function queryParamString(args: { [key: string]: string | undefined }) {
Expand Down Expand Up @@ -632,14 +632,30 @@ async function loginWithLocalhost<ResultType>(
return;
});

server.listen(port, () => {
server.listen(port, "127.0.0.1", () => {
logger.info();
logger.info("Visit this URL on this device to log in:");
logger.info(clc.bold(clc.underline(authUrl)));
logger.info();
logger.info("Waiting for authentication...");

open(authUrl);

const timeoutId = setTimeout(() => {
if (server.listening) {
logger.info();
logger.info(
"Having trouble? Try " +
clc.bold("firebase login --no-localhost") +
" or " +
clc.bold("firebase login:ci"),
);
}
}, 30_000);

server.on("close", () => {
clearTimeout(timeoutId);
});
});

server.on("error", (err) => {
Expand Down