feat: add post-quantum ML-DSA-44 signer, verifier and varsig algorithm#32
Open
alanshaw wants to merge 1 commit into
Open
feat: add post-quantum ML-DSA-44 signer, verifier and varsig algorithm#32alanshaw wants to merge 1 commit into
alanshaw wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds ML-DSA-44 (FIPS 204 ML-DSA) support as a new principal type and varsig signature algorithm so UCANs can be issued/verified using post-quantum did:key keys (backed by filippo.io/mldsa).
Changes:
- Introduces a new varsig signature algorithm codec for ML-DSA-44 (
0x1210). - Adds ML-DSA-44 principal signer (
0x131a) and did:key verifier (0x1210) implementations. - Adds unit tests and wires the new
filippo.io/mldsadependency ingo.mod/go.sum.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| varsig/algorithm/mldsa44/codec.go | Adds ML-DSA-44 varsig signature algorithm codec + registration. |
| principal/mldsa44/verifier/verifier.go | Adds did:key verifier implementation + decoder registration. |
| principal/mldsa44/verifier/verifier_test.go | Tests parsing/encoding/decoding/verifier raw handling. |
| principal/mldsa44/signer.go | Adds signer implementation (keygen/parse/decode/sign). |
| principal/mldsa44/signer_test.go | Tests signer encode/decode, format/parse, signing and raw handling. |
| go.mod | Adds filippo.io/mldsa requirement. |
| go.sum | Adds checksums for filippo.io/mldsa. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+17
to
+21
| func init() { | ||
| keyverifier.Register(Code, func(b []byte) (principal.Verifier, error) { | ||
| return Decode(b) | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ML-DSA-44 (FIPS 204 module-lattice digital signature) as a new principal type, so UCANs can be issued and verified with post-quantum keys in
did:keyform.Uses
filippo.io/mldsauntil Go 1.27 is released (expected August). It is a copy of the reviewed code in the standard library, so it should be a straight swap when available.For consistency with other signers, the ML-DSA-44 signer uses deterministic signing.