Allow quoting legacy remote posts without FEP-044f policies#459
Merged
dahlia merged 1 commit intofedify-dev:mainfrom Apr 29, 2026
Merged
Allow quoting legacy remote posts without FEP-044f policies#459dahlia merged 1 commit intofedify-dev:mainfrom
dahlia merged 1 commit intofedify-dev:mainfrom
Conversation
Treat remote posts without an advertised FEP-044f quote policy as legacy quote targets. Those quotes are accepted immediately instead of waiting for a QuoteRequest response from software that does not implement FEP-044f. Store missing remote quote policy as null while keeping explicit cached FEP-044f policies on the authorization path. Also document that future schema migrations must be generated with pnpm migrate:generate. Assisted-by: Codex:gpt-5.5
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes remote quote handling so cached or newly fetched remote posts without an advertised FEP-044f
canQuotepolicy are treated as legacy quote targets and can be quoted immediately.The
quote_approval_policycolumn is now nullable:NULLrepresents a remote post where no FEP-044f quote policy was observed, while non-null values still represent explicit FEP-044f policies that should use theQuoteRequestauthorization flow.Changes
quote_approval_policyvalues.NULLwhen a remote object has nointeractionPolicy.canQuote.NULLquote policy are accepted immediately, while non-null remote policies remain pending and sendQuoteRequest.NOT NULLand backfill old cached remote public posts toNULL, with a comment documenting the intentional migration tradeoff.Testing
pnpm migrate:generatepnpm test:ci src/api/v1/statuses.test.tspnpm test:ci src/federation/post.test.tspnpm checkgit diff --check