Skip to content

Accept registered WebSocket close codes - #106

Closed
OskarEichler wants to merge 1 commit into
faye:mainfrom
OskarEichler:audit/registered-close-codes
Closed

Accept registered WebSocket close codes#106
OskarEichler wants to merge 1 commit into
faye:mainfrom
OskarEichler:audit/registered-close-codes

Conversation

@OskarEichler

Copy link
Copy Markdown

Add registered close codes 1012, 1013, and 1014. Incoming frames using these IANA-registered values are currently rewritten to protocol error 1002. The full 196-example suite passes on Ruby 4.0.6 and Ruby 3.2.11, as do the cumulative protocol model and native builds.

@jcoglan

jcoglan commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

I mentioned in faye/websocket-extensions-ruby#8 that the Faye project does not accept LLM-authored code. Since all these PRs and the commits they contain were created at the same time, I would suspect they are created by an agent. Have you used any LLM agents or other automation in the production of these PRs?

If the code is your own work, then these PRs would all need unit tests adding to cover their changes, and I'd appreciate if you could check your work using https://github.com/faye/wstest.

@OskarEichler

Copy link
Copy Markdown
Author

Yes—these changes were produced with assistance from an LLM agent. I respect the project policy you shared, so I’m closing this PR and the other open Faye PRs from this batch. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants