Skip to content

WIP: cleanup after vendoring#1690

Draft
svlandeg wants to merge 7 commits intofastapi:drop-clickfrom
svlandeg:feat/vendor_part4
Draft

WIP: cleanup after vendoring#1690
svlandeg wants to merge 7 commits intofastapi:drop-clickfrom
svlandeg:feat/vendor_part4

Conversation

@svlandeg
Copy link
Copy Markdown
Member

@svlandeg svlandeg commented Apr 13, 2026

Continue work from #1525, #1601 and #1680, vendoring Click.

This PR

  • Remove unused code paths with UNSET (originally introduced in this PR). Typer has its own Default(...) to cover these use-cases.
  • Remove unused functionality: FLAG_NEEDS_VALUE, __debug__ statements, batch(), protected_args, Parameter.deprecated
  • Make _click.Command and _click.Parameter abstract

Coverage stats

This branch, before this PR:

13538 statements, 1037 missing (92.3% coverage)

@svlandeg svlandeg self-assigned this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants