fixed issue where .clear was being used in place of mainBG when image…#279
Merged
Conversation
… background set. .clear now localized to InputView and UIList only, recording buttons, reactions etc now correctly use mainBG
fred-bowker
commented
May 27, 2026
| ) { | ||
| self.style = style | ||
| self.images = images | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This code was initially included so that the image background correctly was the background for input view, it worked but had the side effect that other components (recording button) that used mainBg also had there color set to clear
fred-bowker
commented
May 27, 2026
| public let images: ChatTheme.Images | ||
| public let style: ChatTheme.Style | ||
|
|
||
| public var contentBG: Color { |
Contributor
Author
There was a problem hiding this comment.
this allows the .clear to be used instead of mainBG where needed, the InputView and UIList
Collaborator
|
Thank you so much, @fred-bowker, have a marvellous day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… background set.
.clear now localized to InputView and UIList only, recording buttons, reactions etc now correctly use mainBG