Allow nested subtree entries without a file, glob, or url - #120
Open
BetterAndBetterII wants to merge 1 commit into
Open
Allow nested subtree entries without a file, glob, or url#120BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
An entries item that is itself subtrees (no file/glob/url) raised MalformedError. Parse those nested toctrees onto the parent document. Fixes executablebooks#89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_parse_doc_itemrequired everyentriesitem to havefile,glob, orurl. A nestedsubtreesitem (first or later in a subtree) raisedMalformedError.Those nested toctrees are now parsed onto the parent document, and inner file entries are still collected. Caption-only wrappers with no file items are omitted so YAML round-trip stays valid.
Fixes #89