Fix article-header sidebar toggles when navbar content is present - #991
Open
BetterAndBetterII wants to merge 1 commit into
Open
Conversation
Bind every .primary-toggle and .secondary-toggle. querySelector only wired the hidden navbar button pydata-sphinx-theme emits first. Fixes executablebooks#935
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
navbar_*slot is set, pydata-sphinx-theme emits a navbar.primary-toggle/.secondary-toggleearlier in the DOM than the article-header control this theme shows._header-primary.scsshides the navbar buttons, so the visible control is the article-header one.fixSidebarToggleuseddocument.querySelector, which bound only the first (hidden) button. Clicks on the article-header Toggle Sidebar therefore did nothing on desktop.Bind every matching toggle. On wide viewports the handler still toggles
pst-sidebar-hiddenand stops PST from opening a dialog. On narrow viewports it does not intercept, so the dialog path stays with PST.Also covers the empty-
navbar_*case (single article-header button) and the secondary sidebar toggle.Fixes #935