fix(security): clear fuzz lockfile advisories and close the audit gap - #2293
Merged
Conversation
The fuzz workspace lockfile had drifted onto `anyhow` 1.0.102 (RUSTSEC-2026-0190, unsound `Error::downcast_mut()`, patched in 1.0.103) plus yanked `js-sys` 0.3.88 and `wasm-bindgen` 0.2.111. Refreshed to clear all three. Both causes were structural. `crates/bashkit/fuzz` is a separate cargo workspace with its own lockfile, and nothing watched it: CI's `cargo audit` scanned only the root lockfile, and Dependabot's `cargo` entry only covered `directory: "/"`. CI now audits both lockfiles and Dependabot has a matching `/crates/bashkit/fuzz` entry, so this cannot silently recur. Fuzz-only build dependencies, never shipped in the library, so exposure was limited to the nightly fuzz runners.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 751227d | Commit Preview URL Branch Preview URL |
Aug 13 2026, 09:16 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Refreshed
crates/bashkit/fuzz/Cargo.lock, clearing three advisories, and closed the two structural gaps that let them accumulate:/crates/bashkit/fuzzentry, so the fuzz workspace gets weekly updates like every other manifest.Advisories cleared:
anyhowError::downcast_mut()(memory-corruption; patched in 1.0.103)js-syswasm-bindgenWhy
crates/bashkit/fuzzis a separate cargo workspace with its own lockfile, and nothing was watching it.cargo auditin CI scanned only the root lockfile, and Dependabot'scargoentry only covereddirectory: "/". So the fuzz lockfile sat untouched since the v0.16.0 release prep and quietly rotted.Refreshing the lockfile alone would have been a fix with a shelf life — the same drift would recur the moment the next advisory landed. Both watchers are corrected so it cannot silently repeat.
Before / After
Before — the fuzz lockfile was never scanned by CI. Running the scan manually:
After — clean, and now running as part of every CI run:
Fuzz workspace still builds against the refreshed lockfile:
Root workspace audit is unchanged and still clean (2 documented unmaintained warnings, both already in the
deny.tomlignore table).just check-okfandjust check-doc-linkspass.Risk
crates/bashkit/fuzzis test tooling and is never shipped in the published library, so no user-facing surface changes. Exposure was limited to the nightly fuzz runners.cargo check --lockedon the fuzz workspace (compiles clean).chore(deps)PR for fuzz dependencies on its weekly schedule — expected, not a regression.Checklist
Knowledge updated in the same change:
knowledge/security/threat-model.md(two-lockfile audit surface, Dependabot per-workspace requirement) andknowledge/log.md.Generated by Claude Code