feat(check): add radius-decrease liveness check for puller manage() recovery#581
Open
misaakidis wants to merge 2 commits intomasterfrom
Open
feat(check): add radius-decrease liveness check for puller manage() recovery#581misaakidis wants to merge 2 commits intomasterfrom
misaakidis wants to merge 2 commits intomasterfrom
Conversation
Always passing a non-nil ProcMount pointer (even when the value is "") causes k3s to reject the security context, resulting in container termination shortly after start. Guard the field so it is only set when a non-empty ProcMount type is configured. Also bypass the traefik.containo.us IngressRoute code path; clusters that ship Traefik without the legacy CRDs would fail at object creation.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/check/radiusdecrease— a three-phase beekeeper check that validates puller worker liveness after a storage-radius decreaseradius-decreasecheck type inpkg/config/check.goci-radius-decreaseentry toconfig/local.yaml(timeout: 28 m, recovery-timeout: 20 m)Background
When the reserve worker decreases the storage radius it calls
manage(), which callsdisconnectPeer()for every current peer. IfdisconnectPeer()blocks while holdingsyncPeersMtx,manage()freezes indefinitely. This was the root cause of the 14-hour liveness degradation on Gnosis Chain at block 43086913 (depth 10→9 transition).The check triggers the cascade in CI using a patched bee binary (see bee
.github/patches/radius_decrease_*.patch) and verifies thatPullsyncRate > 0returns within 20 minutes of the radius decrease.Test plan
go build ./...)fix/puller-disconnect-backoff—radius-decreasejob passes on the fix branchBEEKEEPER_BRANCHto"master"in the bee workflow