Skip to content

Eslint config different from original #199

Description

@JSlain

I have 2 gulp tasks:

  • running ESLint directly, making my build to fail if any error is discovered
  • running it in Plato to see the result in a friendly UI

I'm also using eslint-plugin-angular to have additional rules.

Here's my problem.
Plato uses a fixed version of ESLint, which is currently 3.0.1
In my project, i use the latest release which 3.4.0 (at the time i'm writing).

The angular plugin injects its rules in the current eslint, which is the 3.4.0 one.

So i have this:

|
+- eslint@3.4.0
|
+- eslint-plugin-angular
|
+- plato
   |
   +- eslint@3.1.0

Both of my tasks uses the same eslint config file, but only the root one (3.4.0) knows about angular rules.
When running plato analysis, there's a bunch of errors about unknown rules...

The workaround is to use the exact same version in my project, and remove/reinstall plato afterward. It'll find its dependency in my project and won't download it again on its own.

The solution is simple

I think plato should really depends on:
"eslint":"^3.0.0"
I don't see any reasons plato should depend on a fixed version. The fixed major version should be fine.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions