Restore the Submodules gitlinks that the #3950 merge turned into symlinks - #4003
Merged
Merged
Conversation
Commit bee7f94 on the two-stream branch replaced every entry under Submodules/ (AMReX, Noah-MP, RRTMGP, WW3, ekat, googletest) with a symbolic link to /home/almgren/TEMP/ERF/Submodules/<name>, a path on one machine, and the merge of erf-model#3950 carried that onto development. A fresh clone then has no AMReX or googletest source, so CMake stops at add_subdirectory. This puts the gitlinks back at the commits recorded just before that change (7ff1672), which are the pointers development had. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit bee7f94 (the last commit on the two-stream branch before the #3950 merge) replaced every entry under
Submodules/(AMReX, Noah-MP, RRTMGP, WW3, ekat, googletest) with a symbolic link to/home/almgren/TEMP/ERF/Submodules/<name>, a path on one machine:The merge commit 50b55ec carried that onto
development. A fresh clone (or the CI checkout) then has no AMReX or googletest source and CMake stops at the firstadd_subdirectory:This puts the six gitlinks back at the commits recorded just before that change (7ff1672), which are the pointers
developmenthad. No submodule is moved to a different commit.Found while starting a build on a fresh worktree of
development; verified bygit submodule update --initand a full CMake configure on this branch.🤖 Generated with Claude Code