Add ens set name command - #9
Merged
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ens set name <name>to generateReverseRegistrar.setNamecalldataaddr.reverseinstead of hardcoding a registrar addressWhy
The CLI could set a reverse record during registration, but had no standalone command for changing an account's reverse record afterward.
Impact
Callers can now generate unsigned calldata for setting the transaction sender's ETH reverse record. The command returns the resolved reverse registrar alongside
to,data, andvalue.A reverse record is one half of a primary name. Primary-name resolution is functional only when the supplied name also forward-resolves to the same address.
Validation
bun run typecheckbun test --pass-with-no-tests(repository currently contains no test files)bun run buildgit diff --check