Repository navigation
Introduce transports as a module - #121
Merged
Merged
Conversation
Comment on lines
+39
to
+44
| class Transport: | ||
| def send(self, request: Request) -> ResponseStream: | ||
| raise NotImplementedError() | ||
|
|
||
| def close(self): | ||
| pass |
| ) -> ResponseStream: | ||
| request = Request(method, url, headers=headers, content=content) | ||
| return self.send(request) | ||
| from .._body import GZipStream, HTTPStream |
Member
There was a problem hiding this comment.
Observation... Not sure these are in the right place. (Not part of this PR, just a reminder)
Collaborator
Author
There was a problem hiding this comment.
Do we have a related issue?
| from .._urls import URL | ||
| from .base import ResponseStream, Transport | ||
|
|
||
| __all__ = ["Connection", "open_connection"] |
Member
There was a problem hiding this comment.
Good little reminder here that we should refactor Connection to remove the open_connection helper.
Mentioned in #99.
cgl
force-pushed
the
refactor/package-transports
branch
from
November 2, 2026 15:06
c84e8f3 to
d9bd9fb
Compare
cgl
force-pushed
the
refactor/package-transports
branch
from
November 2, 2026 15:14
d9bd9fb to
bce08ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#116