Skip to content

WRP-4076:Button: add missing @mixes tag for TooltipDecorator - #1419

Merged
juwonjeong merged 1 commit into
developfrom
feature/WRP-4076
Mar 14, 2023
Merged

juwonjeong merged 1 commit into
developfrom
feature/WRP-4076

Conversation

@hoeunryuLG

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Currently, TooltipDecorator is missing from includes for ButtonDecorator description on enactjs.com.
ButtonDecorator is composed of TooltipDecorator, but @mixes tag for TooltipDecorator is missing in the documentation.

Resolution

Add @mixes tag for TooptipDecorator.

Additional Considerations

Links

WRP-4076
enactjs/agate#735

Comments

Enact-DCO-1.0-Signed-off-by: Hoeun Ryu hoeun.ryu@lge.com

ButtonDecorator is composed with TooltipDecorator, but @mixes tag for
TooltipDecorator is missing in the document. Add @mixes tags for
TooltipDecorator.

Enact-DCO-1.0-Signed-off-by: Hoeun Ryu <hoeun.ryu@lge.com>
@codecov

codecov Bot commented Mar 10, 2023 •

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (d6ec652) 79.24% compared to head (902e596) 79.24%.

❗ Current head 902e596 differs from pull request most recent head 17fdec0. Consider uploading reports for the commit 17fdec0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1419   +/-   ##
========================================
  Coverage    79.24%   79.24%           
========================================
  Files          136      136           
  Lines         6380     6380           
  Branches      1886     1886           
========================================
  Hits          5056     5056           
  Misses        1008     1008           
  Partials       316      316           
Impacted Files Coverage Δ
Button/Button.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juwonjeong juwonjeong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juwonjeong
juwonjeong merged commit 0510866 into develop Mar 14, 2023
@juwonjeong
juwonjeong deleted the feature/WRP-4076 branch March 14, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants