NXT-19990: Fixed long press scroll between multiple VirtualLists - #432
Merged
Merged
Conversation
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/1.11.x.develop #432 +/- ##
=========================================================
Coverage ? 82.67%
=========================================================
Files ? 153
Lines ? 7619
Branches ? 2316
=========================================================
Hits ? 6299
Misses ? 1026
Partials ? 294 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
daniel-stoian-lgp
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
When holding down a down key (long press) to move between multiple horizontally-arranged VirtualLists,
focus stopped and did not continue to the last one.
Resolution
In #361,
isFirstEntryRepeatwas defined to block the scroll when entered a VirtualList from outside with long press.Here, keyDown event handler is blocked if
isFirstEntryRepeatis true, which means key was pressed before entering the VirtualList and there wasn't a new key press. this makes scroll can newly start in the VirtualList after new key press.But in case of focus move between VirtualLists, not between Items in a VirtualList, keyDown handler is needed to keep focus moving between the VirtualLists.
The condition of
isFirstEntryRepeatshould be detect the focus is moving within the VirtualList or not.So I added
isMovingWithinListcondition.Additionally, I added
isMovingWithinListcontidion inisOutdatedIndexto prevent a possible issue.Additional Considerations
Links
NXT-19990
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)