NXT-19371: resolve webpack version mismatch causing parser.getLocatio… - #874
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #874 +/- ##
========================================
Coverage 85.60% 85.60%
========================================
Files 118 118
Lines 4495 4495
Branches 1226 1226
========================================
Hits 3848 3848
Misses 503 503
Partials 144 144 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| @@ -1,22 +0,0 @@ | |||
| diff --git a/node_modules/storybook/dist/manager/globals-runtime.js b/node_modules/storybook/dist/manager/globals-runtime.js | |||
Contributor
There was a problem hiding this comment.
same here. why was this removal needed?
Contributor
Author
There was a problem hiding this comment.
I had deleted this patch because it caused a build error.
Upon re-verification, I found that the patch was incompatible with the Storybook version, so I recreated it as v10.5.10.
daniel-stoian-lgp
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
The build fails during the Storybook webpack build with:
Two conflicting webpack versions are installed simultaneously:
devDependencies(the "host" webpack used by Storybook)@enact/dev-utils/node_modules/(resolved from peer dependencies)When
@enact/dev-utils'sILibPlugindoesrequire('webpack'), it resolves to the nested 5.109.2 copy. TheDefinePluginfrom 5.109.2 registers parser hooks that callparser.getLocation()— a method introduced in webpack 5.108+. However, the actual parser instance comes from the host's webpack 5.107.2, which does not have this method, causing theTypeError.Resolution
^10.4.6to^10.5.10to align with the version npm resolves for nested dependenciesAdditional Considerations
Links
NXT-19371
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)